Skip to content

Use schema-owned asset cache models#1950

Merged
benflexcompute merged 3 commits intoBenY/CentralizedSchemafrom
BenY/AssetCacheMigration
Apr 2, 2026
Merged

Use schema-owned asset cache models#1950
benflexcompute merged 3 commits intoBenY/CentralizedSchemafrom
BenY/AssetCacheMigration

Conversation

@benflexcompute
Copy link
Copy Markdown
Collaborator

@benflexcompute benflexcompute commented Apr 2, 2026

Summary

  • switch client-side runtime consumers to schema-owned asset-cache payload models
  • keep the Transformation relay available from the schema legacy module after the schema-side split
  • preserve runtime manager ownership on the client side

Validation

  • poetry run pytest -c tests/pytest.ini -rA tests/simulation

Note

Medium Risk
Moderate risk because it swaps core AssetCache/draft status model definitions over to the external flow360-schema package (plus a dependency bump), which can affect serialization/validation behavior and draft persistence if the schema changes are not fully compatible.

Overview
Migrates client/runtime consumers to use schema-owned asset cache and draft status payload models: AssetCache, MirrorStatus, CoordinateSystemStatus (and related coordinate-system assignment models) plus MirrorPlane are now imported from flow360_schema instead of being defined in flow360.

Keeps API compatibility by relaying Transformation from flow360_schema.framework.entity.legacy_transformation after the schema split, and updates param/translator/util code paths to treat schema AssetCache as the skippable container during entity traversal/replacement.

Updates tests to reflect the move (removing validations/tests that were tied to the old in-repo models) and bumps flow360-schema to 0.1.19 in poetry.lock.

Written by Cursor Bugbot for commit 0acdf37. This will update automatically on new commits. Configure here.

@benflexcompute benflexcompute marked this pull request as ready for review April 2, 2026 14:31
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Coverage report (flow360)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  flow360/component
  project.py
  project_utils.py
  flow360/component/simulation
  entity_operation.py
  simulation_params.py
  flow360/component/simulation/draft_context
  context.py
  coordinate_system_manager.py
  mirror.py
  flow360/component/simulation/framework
  boundary_split.py
  entity_materializer.py
  param_utils.py 21
  flow360/component/simulation/translator
  utils.py
Project Total  

This report was generated by python-coverage-comment-action

@benflexcompute benflexcompute merged commit 4a7d3d9 into BenY/CentralizedSchema Apr 2, 2026
35 checks passed
@benflexcompute benflexcompute deleted the BenY/AssetCacheMigration branch April 2, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants