Use schema-owned asset cache models#1950
Merged
benflexcompute merged 3 commits intoBenY/CentralizedSchemafrom Apr 2, 2026
Merged
Use schema-owned asset cache models#1950benflexcompute merged 3 commits intoBenY/CentralizedSchemafrom
benflexcompute merged 3 commits intoBenY/CentralizedSchemafrom
Conversation
Contributor
Coverage report (flow360)Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
angranl-flex
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Transformationrelay available from the schema legacy module after the schema-side splitValidation
poetry run pytest -c tests/pytest.ini -rA tests/simulationNote
Medium Risk
Moderate risk because it swaps core
AssetCache/draft status model definitions over to the externalflow360-schemapackage (plus a dependency bump), which can affect serialization/validation behavior and draft persistence if the schema changes are not fully compatible.Overview
Migrates client/runtime consumers to use schema-owned asset cache and draft status payload models:
AssetCache,MirrorStatus,CoordinateSystemStatus(and related coordinate-system assignment models) plusMirrorPlaneare now imported fromflow360_schemainstead of being defined inflow360.Keeps API compatibility by relaying
Transformationfromflow360_schema.framework.entity.legacy_transformationafter the schema split, and updates param/translator/util code paths to treat schemaAssetCacheas the skippable container during entity traversal/replacement.Updates tests to reflect the move (removing validations/tests that were tied to the old in-repo models) and bumps
flow360-schemato0.1.19inpoetry.lock.Written by Cursor Bugbot for commit 0acdf37. This will update automatically on new commits. Configure here.